Sound association problem in kof94 & 95

[ffman1985]

Some sound association problems happen in the newer version of raine. During the battle in kof94 & 95, sometimes, when there are some special hit sound effect (eg from the art of fighting members in kof94), it may lead to the music stops completely or switches to some other music track.

Edited September 12, 2022 by ffman1985

[Tux]

Specific to a particular stage or any battle ? There was no change in the current version for this so it's probably an old problem

Well I can't seem able to reproduce this in kof94 (but I am not a good player !), so I'll need a lot more details !

Edited September 12, 2022 by Tux

[ffman1985]

It can happen in any stage with very high frequency. I think it is easier to see the problem in kof95 (just play normally). As for kof94, using art of fighting members will easier to occur.
It happens not only in current version, in fact, this exists long time ago. 

Edited September 12, 2022 by ffman1985

[mer-curious]

Hello guys!

If you allow me to help, I was able to reproduce the "music stop" sound association issue in KOF95. I don't really know if it is indeed related to the Art of Fighting team (Ryo, Robert and Takuma characters), but I was using these characters as recommended by ffman1985.

Gladly I was doing save states before every round started so I think I found a good place to easily reproduce it. You just have to hit the character Kyo with any punches or kickes. It doesn't matter if he guards or not your attacks, as long as they reach him.

Here's the file:

https://drive.google.com/file/d/1L1kd7eqmGFS9Nt5FjBJkBwUn9iYOuGja/view?usp=sharing

Hopefully you both will be able to reproduce it in your setups.

Curiously I had already experienced this music stop (and possibly the music change) issue in KOF98 before, but it happened so randomly during a match that I couldn't even find a safe way to reproduce it in order to file a bug report here in the forum, so I just forgot about it for a while hoping that I could finally reproduce it again some day. Well, maybe this day has come? Hopefully the KOF95 bug will be the same as the one in KOF94 and KOF98.

I'm also posting my associations configuration for KOF95 in case you need it, here:

[kof95:assoc]
33 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 02.mp3
34 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 09.mp3
loop34 = 1
35 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 11.mp3
loop35 = 1
36 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 13.mp3
loop36 = 1
37 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 16.mp3
loop37 = 1
38 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 19.mp3
loop38 = 1
39 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 21.mp3
loop39 = 1
40 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 23.mp3
loop40 = 1
41 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 25.mp3
loop41 = 1
42 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 29.mp3
loop42 = 1
43 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 39.mp3
44 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 04.mp3
loop44 = 1
45 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 27.mp3
46 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 28.mp3
48 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 06.mp3
49 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 08.mp3
51 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 31.mp3
52 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 36.mp3
53 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 37.mp3
54 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 38.mp3
55 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 33.mp3
loop55 = 1
56 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 03.mp3
loop56 = 1
57 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 35.mp3
80 = d:\unzipped\games\NEO-GEO CD\King of Fighters '95\King of Fighters 95 - Track 41.mp3

The track that plays in the save state is track 09.

Thank you for your attention! 👍

Edited September 13, 2022 by mer-curious

[Tux]

kof98 is a completely different game for the associations, not at all comparable with kof94/95 sorry. So changes for these 2 will not impact kof98 at all. These 2 category includes galaxyfg, 3countb, fatfury2, fatfury3... and so it's a problem to know if the change detected here is specific to kof94/95, or general to all these games, so it will take quite some time to test all that.

edit : it seems there is a new prefix for the sound commands, this makes a new experimental build to test, 64 bits only since that's what mer-curious uses, it seems to work for kof95, maybe for kof94 (I was not able to reproduce the problem here), but expect no change for kof98. For info I found this while making no real associations for the game, I just used the debug messages I get in a debug build which tell if the song changes... !

exp.7z

Edited September 13, 2022 by Tux

[ffman1985]

After testing kof94, I find that the problem of 94 is not as serious as 95. It is obviously that using Ryo (Mexico member) always cause problems. Simply press abc together, after Ryo gains maximum power, the music change. Here is the sound list for kof94:

[kof94:assoc]
33 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 02.mp3
loop33 = 1
34 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 03.mp3
loop34 = 1
35 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 04.mp3
loop35 = 1
36 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 05.mp3
loop36 = 1
37 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 06.mp3
loop37 = 1
38 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 07.mp3
loop38 = 1
39 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 08.mp3
loop39 = 1
40 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 09.mp3
loop40 = 1
41 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 10.mp3
loop41 = 1
42 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Opening(JP Ver).mp3
43 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 11.mp3
loop43 = 1
44 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 17.mp3
48 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 12.mp3
49 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 13.mp3
50 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 14.mp3
loop50 = 1
52 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 18.mp3
53 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 19.mp3
64 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 15.mp3
65 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 16.mp3
81 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Opening(USA Ver).mp3
82 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 22.mp3
83 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 23.mp3
84 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 23.mp3
85 = D:\Games\Neo Geo CD\The King of Fighters 94\King of Fighters 94 - Track 23.mp3

[ffman1985]

Update:

I try to use the.exe provided above, it seems that the problem in kof94 is solved. However, in kof95, there are still some problems. Please download the following savestate. When Rugal win the match and hurt himself, the music disappeared (you may need to reload the save a few times to get that winning post).

https://drive.google.com/file/d/1nB2tgwSpzAnMYvKwYRQcefGhd1lQ7n6W/view?usp=sharing

[Tux]

Sorry I can't reproduce anything with this save, the graphics are totally garbled when loading it, I don't know how you did that, but the game is not frozen, it still reacts to inputs, I can press a+b+c to get to full power but it has no effect on any music playing or not. After that a makes the final punch, victory, and still nothing happens for the music.

Ok, finally did it, there are random sounds playing, one of them stops the music, which gives us 2 more prefix commands, because I tested some more manually, and another test build. This one should be good everywhere, assuming it doesn't break things in the other games of this kind, but it shouldn't.

exp.7z

Edited September 13, 2022 by Tux

[ffman1985]

For pressing abc to get full power using Ryo to stop the music is the problem of kof94.

For the kof95 save I provided, if you can input, simply press c button to kill the opponent, the music have 50% chance to stop, depends on the winning post of the character.

[Tux]

Yeah replied the post just before this one, happy testing !

[mer-curious]

8 hours ago, Tux said:

kof98 is a completely different game for the associations, not at all comparable with kof94/95 sorry. So changes for these 2 will not impact kof98 at all. These 2 category includes galaxyfg, 3countb, fatfury2, fatfury3... and so it's a problem to know if the change detected here is specific to kof94/95, or general to all these games, so it will take quite some time to test all that.

edit : it seems there is a new prefix for the sound commands, this makes a new experimental build to test, 64 bits only since that's what mer-curious uses, it seems to work for kof95, maybe for kof94 (I was not able to reproduce the problem here), but expect no change for kof98. For info I found this while making no real associations for the game, I just used the debug messages I get in a debug build which tell if the song changes... !

exp.7zUnavailable

Hello Tux! I wasn't able to test this very experimental version because the forum says the attachment is "unavailable". But I did try the second one which you posted later and could no longer reproduce the music stop issue in KOF95. I tried both my save state and ffman1985's one with Rugal. By the way, I also experienced the graphics corruption in his save file. I wonder how he triggered that? Perhaps he could provide some more details...

I also went and tried to reproduce the music change issue reported by ffman1985 in KOF94 and could replicate it consistently here by pressing ABC together to fill the power gauge with the Ryo character. Gladly this issue has also been fixed by the test version you provided.

And just to correct what I said about KOF98, I experienced the "music stop" issue there once, but the "music change" bug was actually noticed in Art of Fighting 3. Unfortunately I wasn't able to reproduce it there easily to file a bug report, so I simply let it pass.

Anyway, I hope that your fix for KOF94 and 95 can also work for AOF3 at least. I'll see if I can eventually reproduce the issue in KOF98 again.

Thank you so much for your work.

[Tux]

Yeah aof3 is a "type 2" too, so it's affected by these changes. Your gui "fix" is inside too, so this binary can be considered a 0.94.2... except the code for it was very short, so I'll wait some more but you can use this meanwhile !

[ffman1985]

Hello everyone, my save file above is made either from version 64bit 9.35 or 9.41 (from 1st exe file provided by Tux)(Sorry that I forget about it). The rom use is kof95.zip (no hack, original). Anyway, the save file works in both version for me. It is possible that we are using different rom.

I try the 2nd exe file from Tux, the problems of kof94 & 95 are solved. It also solves the problem in Fatal Fury 3 Ending Music. Thank you very much for the help.

[ffman1985]

Hello mer-curious, do you remember which music track cause problem in kof98? It is worth to note that the ‘Here come a new challenger’ music is the combination of track25 & track06 of ngcd. If you did not combine the tracks but using track25 only, it may look like music stop.

Also, it seems that you have created sound list for many games, can you share the list?

Edited September 13, 2022 by ffman1985

[mer-curious]

4 hours ago, ffman1985 said:

Hello everyone, my save file above is made either from version 64bit 9.35 or 9.41 (from 1st exe file provided by Tux)(Sorry that I forget about it). The rom use is kof95.zip (no hack, original). Anyway, the save file works in both version for me. It is possible that we are using different rom.

Hello ffman1985! It's interesting to know that the save state file works for you and not for Tux and me. Did you happen to use unibios 4.0 when you created it? This is the bios I'm using here. Perhaps a different bios setting could trigger the corruption? The setup in the unibios for me is "Japan" and "Console".

I don't think the romset we use could be different because it has been widely made available in the internet for many years, so we probably use the same roms. If you want to compare, here is a screenshot of my romset with the CRC codes:

https://imgur.com/a/1jLj1DP

Interestingly, I think I have already experienced this kind of corruption in a save state before when playing Art of Fighting 3. I couldn't reproduce it to file a bug report and so I just forgot about it for a while. Unfortunately we need to be able to trigger the corruption so Tux can check it and fix it.

If you had a save state before the one you shared here maybe we could trigger the corruption from it and possibly fix it.

 

3 hours ago, ffman1985 said:

Hello mer-curious, do you remember which music track cause problem in kof98? It is worth to note that the ‘Here come a new challenger’ music is the combination of track25 & track06 of ngcd. If you did not combine the tracks but using track25 only, it may look like music stop.

If I'm not mistaken, it was in the last stage of a normal team play. I was playing against the Masters Team (Heidern, Takuma and Saisyu) in the Japan Temple stage. I was possibly using the Korea Team (Kim, Chang and Choi), but I don't remember exactly the characters I was using. Yes, I know the "Here comes a new challenger" sound command is divided in two different tracks in the NGCD version. I have edited both tracks in a single one using a sound editor. If you don't have it, you can grab it here:

https://drive.google.com/file/d/1OUfecbMG0TMk11EDDNIgoAThyHzmIx34/view?usp=sharing

 

4 hours ago, ffman1985 said:

Also, it seems that you have created sound list for many games, can you share the list?

I have created sound associations mostly for the games which had sprites cut in the conversion for the NGCD. So for instance, I didn't have sound associations for KOF94 because the NGCD conversion is perfect as far as I know (maybe that's why I never realized the sound issues you have reported here), so I just use the KOF94 for NGCD if I want to play the game with the arranged sound tracks. But I haven't tested many games to be sure about the sprites cut. It's probable that, for instance, the Samurai Spirits franchise have received either sprites cut or sprites censorship in the NGCD conversions, so for these games the sound associations would be welcome, but since I don't play these games much I haven't created the associations yet.

It would be a great idea if we had here in the forum a data base for sound associations. If this feature ever comes to other emulators the emulation community would surely benefit from our work here. I have always had this idea but it is a little time consuming to check all the games and create associations for all of them.

Here's my games.cfg file with all the associations that I currently have:

https://drive.google.com/file/d/1LpbYDWrc16tmuQMuY2LSLL3H8cekTkNO/view?usp=sharing

Thank you for your attention.