mamesick

Looks like that the sorted_source stuff is no more needed and can be deleted safely. IIRC it was used in datafile.cpp but I just noticed you completely rewrite the code there so it isn't used anymore.

If my memories are still correct... that sorted_source is used in datafile.cpp for faster access to source files list when displaying mameinfo.dat details, in particular the info about source files.

Perfect. Yes, the fast audit is fine at my home. For something I cannot explain it crashes here at work. Maybe a RAM problem.

This problem is fixed in the post above. Yes, if you change Custom Filter in 0.232 the GUI will crash silently on exit and nothing will be saved. Assuming @Robertwill implement my fixes, the next 0.233 should work fine for all users. Yes, all options are saved in a special order. For the interface ones, first we check for the Custom Filters (if they changed or not) and then we save all the rest. Of course, if saving Filters is causing a crash, all the rest will not be saved at all.

The file you're looking for is \GUI\GAMESTAT.INI. I re-checked with a fresh installation of ARCADE 0.232, I put a ROM into the \roms\ folder for testing. Audit All Games worked as expected, the audit results were saved when I closed the app and loaded correctly when I launched it again. Another bug instead appeared. If I enable "Faster Audit method" in the Interface Options and perform an Audit All Games, the program badly crashes after a while. I don't know if it's my PC here at work or not, I have to check better. If someone else could check it would be great. @Robert

Looks like I also fixed the Custom Filters problem/crash. A simply change in line 144 of \WINUI\WINUI_OPTS.CPP: { "_filters", "0", OPTION_STRING, nullptr }, Last one, these three lines should be deleted because they create the useless MAME.INI in the root folder which is not used at all: lines 1896, 1897, 1898 // if .\mame.ini not exist, create a default one std::string filename = std::string(DEFAULT_INI_FILENAME).append(".ini"); LoadOptionsStartup(core_opts, filename); and change line 1900: std::string filename = std::string(GetIniDir()).append(PATH_SEPARATOR).append(DEFAULT_INI_FILENAME).append(".ini"); That's all. I have no idea what to do with the Audit All Games issue reported here, on my side it works as expected. @Robert

The crash with BIOS change/selection in the GUI is confirmed. The option is saved in a corrupted way. A "good" fix seems to change line 2918 and line 2956 in \WINUI\PROPERTIES.CPP to: const char *biosname = core_strdup(ROM_GETNAME(rom)); this will alloc some extra not wanted memory, so at the end we should use: biosname = NULL; At least now it works. @Robert

I can confirm the ugly bug. It seems nothing is saved on exit. Though, if you don't change the Custom Filters, all is working as expected and all options are correctly saved on exit. The MAME.INI that is generated on the root is useless and should be deleted manually. It's not used at all, when you change something in the Default Options the changes are correctly saved in \INI\MAME.INI and parsed correctly when you launch a game.

Windows 10 users should follow the updated link, though... https://danantonielli.com/app-scaling-on-high-dpi-displays-fix-2019/ I don't know if it will work or not, I'm still on an old 1366x768 PC monitor.

I really don't see why people waste their time in manually editing the .INIs when there's a well-tested and professional GUI to configure those options: You don't need to edit PLUGINS.INI. You can configure all the plugins you want from the GUI in a very easy way. This can be done globally or per single game (right-click on a game the select "Properties for..."

Easiest way is right-click on a game and select "Add to Custom Folder". Then simply choose the desidered folder. If no choice present, simply create a custom folder following Hyperscorpio instructions.

IIRC Robbert completely removed NEOGEO raster hack a while ago, in favour of original MAME code. NAMCONB1 is still needed. Those changes don't fix the terrible slowdowns in Nebulas Ray on some levels due to performing raster effects on sprites, when probably the original hardware doesn't do that. Also there's a fix for a 1 pixel offset line in raster irq. SIMPSONS is still needed. Those changes don't fix the music speed bug. Audio CPU still must be overclocked

Yes, it seems that it's fixed now. At least for the few games I tested.

My two cents are that maybe it would be better make an HBARCADE build, with all the arcade-only hacks supported by HBMAME developed using the ARCADE GUI code. I cannot help because I'm lack of time due to my real life job and sincerely also because I'm not interested. Though I have no objections. Good luck with the neogeo-decrypted driver.

You might want to add a couple of changes in this piece of code at line 4865 in WINUI.CPP, to ensure that the TreeView repainting after the View-->Show Folders menu action doesn't show garbage: void ToggleShowFolder(int folder) { int current_id = GetCurrentFolderID(); SetWindowRedraw(hWndList, false); SetShowFolder(folder, !GetShowFolder(folder)); ResetTreeViewFolders(); SelectTreeViewFolder(current_id); SetWindowRedraw(hWndList, true); } change to: void ToggleShowFolder(int folder) { int current_id = GetCurrentFolderID(); SetWindowRedraw(hWndList, false); SetWindowRedraw(hTreeView, false); SetShowFolder(folder, !GetShowFolder(folder)); ResetTreeViewFolders(); SelectTreeViewFolder(current_id); SetWindowRedraw(hTreeView, true); SetWindowRedraw(hWndList, true); }