Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Sign in to follow this  
JonBoyRetro

The 'Show Folders' option doesn't appear to work

Recommended Posts

HI Robert, sorry, not trying to find issues honest! The 'View >Show Folders' doesn't appear to work. It has a go when you un-check the item - but it still shows.

If you hide, say, Dumping Status, you get this in interface.ini:

hide_folders              sound
 

I can force it to hide folders by amending interface.ini as follows:

hide_folders              "bios, clones, cpu, dumping status, horizontal, lightgun, mechanical, manufacturer, raster, refresh, samples, resolution, screens, sound, source, savestate, trackball, unavailable, vector, vertical, working, year, imperfect"

However, this is a bit unreliable and I still can't hide 'BIOS' !

All the best, JBR

Share this post


Link to post
Share on other sites

You can get it to work properly by right-clicking on a folder, and choose the Show Folders menu that appears in there.

I'm looking at why the View, Show Folders isn't working.

Share this post


Link to post
Share on other sites

IIRC the View-->Show Folders is hardcoded in source and is based on the order that you can find in TREEVIEW.CPP. If you have altered in some way that order during the treeview panel creation (e.g. you used TVI_SORT or something similar) the order is now broken. Search also in WINUI.CPP for the piece of code that builds this menu option, it should be were all the bitmaps menu icons are created. The variable should be ID_SHOW_FOLDER_START## and is also hardcoded in MAMEUI.RC

 

Share this post


Link to post
Share on other sites

The problem has been fixed, and I took the chance to clean up that bit of code. ID_SHOW_FOLDER_START1 thru 28, have been removed, replaced by ID_SHOW_FOLDER_START and ID_SHOW_FOLDER_END, same idea as the right-click menu uses.

Share this post


Link to post
Share on other sites

You might want to add a couple of changes in this piece of code at line 4865 in WINUI.CPP, to ensure that the TreeView repainting after the View-->Show Folders menu action doesn't show garbage:

void ToggleShowFolder(int folder)
{
	int current_id = GetCurrentFolderID();

	SetWindowRedraw(hWndList, false);
	SetShowFolder(folder, !GetShowFolder(folder));
	ResetTreeViewFolders();
	SelectTreeViewFolder(current_id);
	SetWindowRedraw(hWndList, true);
}

change to:

void ToggleShowFolder(int folder)
{
	int current_id = GetCurrentFolderID();

	SetWindowRedraw(hWndList, false);
	SetWindowRedraw(hTreeView, false);
	SetShowFolder(folder, !GetShowFolder(folder));
	ResetTreeViewFolders();
	SelectTreeViewFolder(current_id);
	SetWindowRedraw(hTreeView, true);
	SetWindowRedraw(hWndList, true);
}

 

Edited by mamesick
  • Thanks 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this  

×
×
  • Create New...