Jump to content

ARCADE 0.204


Robert
 Share

Recommended Posts

  • 3 weeks later...

One of users from BYOAC reported that sound fix for Dark Seal does not work. Version 203 and 204 have this problem it seems. Version 201 seems to be fine.

 

201 diff

 

 	map(0x140000, 0x140001).r(m_soundlatch, FUNC(generic_latch_8_device::read));
 	map(0x1f0000, 0x1f1fff).ram();
-	map(0x1fec00, 0x1fec01).rw(m_audiocpu, FUNC(h6280_device::timer_r), FUNC(h6280_device::timer_w)).mirror(0x3fe);
+	map(0x1fec00, 0x1fec01).r(m_audiocpu, FUNC(h6280_device::timer_r)).mirror(0x3fe); // .w(FUNC(h6280_device::timer_w)); // MAMEFX MT 00130
 	map(0x1ff400, 0x1ff403).rw(m_audiocpu, FUNC(h6280_device::irq_status_r), FUNC(h6280_device::irq_status_w)).mirror(0x3fc);

202 diff

 

 	map(0x140000, 0x140001).r(m_soundlatch, FUNC(generic_latch_8_device::read));
 	map(0x1f0000, 0x1f1fff).ram();
+	map(0x1fec00, 0x1fec01).r(m_audiocpu, FUNC(h6280_device::timer_r)).mirror(0x3fe); // .w(FUNC(h6280_device::timer_w)); // MAMEFX MT 00130
+	map(0x1ff400, 0x1ff403).rw(m_audiocpu, FUNC(h6280_device::irq_status_r), FUNC(h6280_device::irq_status_w)).mirror(0x3fc);

 

Edited by haynor666
Link to comment
Share on other sites

The fix for darkseal and vaportra is no more valid. The function that is commented out is now declared internally in the H6280 CPU core and is always enabled. So those extra lines listed in 202 diff are useless now.

In file h6280.cpp infact there is:

void h6280_device::internal_map(address_map &map)
{
	map(0x1fe800, 0x1fe80f).mirror(0x3f0).rw(FUNC(h6280_device::io_buffer_r), FUNC(h6280_device::psg_w));
	map(0x1fec00, 0x1fec01).mirror(0x3fe).rw(FUNC(h6280_device::timer_r), FUNC(h6280_device::timer_w));
	map(0x1ff000, 0x1ff000).mirror(0x3ff).rw(FUNC(h6280_device::port_r), FUNC(h6280_device::port_w));
	map(0x1ff400, 0x1ff403).mirror(0x3fc).rw(FUNC(h6280_device::irq_status_r), FUNC(h6280_device::irq_status_w));
}

So the only way to enable again the fix would be comment out the line here but with the serious risk to break a lot of other games that uses the same audio CPU.

Robbbert should remove both VAPORTRA.CPP and DARKSEAL.CPP files from his source. The code there is no more valid.

Link to comment
Share on other sites

Because of this, darkseal and vaportra have been reverted back to MAME standard.

 

If someone wants to check the existing audio in everything else that uses the h6280, then we will know if it's a global problem, or just for some games. If it happens for everything h6280-related, then the patch can be done.

Link to comment
Share on other sites

Let remind you guys, if you want more Tourvision PCE games just go to PD and grab the MAME 0.204 Software List ROMs (merged) with this 2 folder sets.

pce - 299 games

pce_tourvision - 110 games

 

409 games in Total!

 

Soon will apply 205 version, hoping for new games :msntongue:

 

Merry Christmas!!! :matrix:

Edited by Hyperscorpio
Link to comment
Share on other sites

The fix for darkseal and vaportra is no more valid. The function that is commented out is now declared internally in the H6280 CPU core and is always enabled. So those extra lines listed in 202 diff are useless now.

In file h6280.cpp infact there is:

void h6280_device::internal_map(address_map &map)
{
	map(0x1fe800, 0x1fe80f).mirror(0x3f0).rw(FUNC(h6280_device::io_buffer_r), FUNC(h6280_device::psg_w));
	map(0x1fec00, 0x1fec01).mirror(0x3fe).rw(FUNC(h6280_device::timer_r), FUNC(h6280_device::timer_w));
	map(0x1ff000, 0x1ff000).mirror(0x3ff).rw(FUNC(h6280_device::port_r), FUNC(h6280_device::port_w));
	map(0x1ff400, 0x1ff403).mirror(0x3fc).rw(FUNC(h6280_device::irq_status_r), FUNC(h6280_device::irq_status_w));
}

So the only way to enable again the fix would be comment out the line here but with the serious risk to break a lot of other games that uses the same audio CPU.

Robbbert should remove both VAPORTRA.CPP and DARKSEAL.CPP files from his source. The code there is no more valid.

 

How exactly I should modified this file, I'm going to test other titles using this processor? Looks like another game is affected - https://mametesters.org/view.php?id=7181

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

×
×
  • Create New...